Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost: make Concatenate modules work more consistently #40224

Open
wants to merge 4 commits into
base: trunk
Choose a base branch
from

Conversation

donnchawp
Copy link
Contributor

@donnchawp donnchawp commented Nov 18, 2024

The CSS and JS Concatenate modules do not work in the same way other modules on the settings page work. This PR update them to fix that.
Instead of a cancel button, it uses the same show hide link other modules use, with up/down chevrons. I think I'd rather leave the text of the link, instead of changing it to "Hide" as the cursor has to be moved if it was not in the right place.
If the text input form is closed, the value of the form is reset to the saved value now. It would retain an edited version before, unlike other modules.

Fixes #36274

Proposed changes:

  • Wrap the SCSS in a wrapper selector and adjust CSS to work.
  • Use an up/down chevron to show and hide the meta form.
  • Show/hide link uses isExpanded state like other modules now.
  • Remove the Cancel button
  • Add a description and help text.
  • Remove inputLabel parameter from MetaComponent as it uses datasyncKey to decide if JS or CSS.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Go to settings page and open and close the two modules
  • Edit the settings and save them.
  • Reload the page to confirm the changes stick.

@donnchawp donnchawp added [Status] In Progress [Plugin] Boost A feature to speed up the site and improve performance. labels Nov 18, 2024
@donnchawp donnchawp self-assigned this Nov 18, 2024
Copy link
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Boost plugin:

  • Next scheduled release: none scheduled.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Boost A feature to speed up the site and improve performance. [Status] In Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Boost] Update Minify/Concat CSS/JS UI
1 participant