Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle null speech URLs with fallback to empty string #2158

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sebastianbuzdugan
Copy link

@sebastianbuzdugan sebastianbuzdugan commented Nov 17, 2024

Purpose

This change resolves a TypeScript error where null speech URLs caused a type mismatch by using a fallback to an empty string. It ensures smooth operation when speech URLs are missing.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error?
If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Does this require changes to learn.microsoft.com docs?

This repository is referenced by this tutorial
which includes deployment, settings and usage instructions. If text or screenshot need to change in the tutorial,
check the box below and notify the tutorial author. A Microsoft employee can do this for you if you're an external contributor.

[ ] Yes
[x] No

Type of change

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

  • The current tests all pass (python -m pytest).
  • I added tests that prove my fix is effective or that my feature works
  • I ran python -m pytest --cov to verify 100% coverage of added lines
  • I ran python -m mypy to check for type errors
  • I either used the pre-commit hooks or ran ruff and black manually on my code.

@pamelafox pamelafox changed the title fix: handle null speech URLs with fallback to empty string to resolve… fix: handle null speech URLs with fallback to empty string Nov 18, 2024
@@ -44,7 +44,7 @@ export const SpeechOutputAzure = ({ answer, speechConfig, index, isStreaming }:
return;
}
if (speechConfig.speechUrls[index]) {
playAudio(speechConfig.speechUrls[index]);
playAudio(speechConfig.speechUrls[index] ?? "");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

playAudio doesn't seem to have a special check for empty string, besides the catch expression. Does this end up being handled by that catch? Did you find it was better to do this than to add a guard for length and only call playAudio for non-empty strings?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants