-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenTelemetry Metrics: Adds support to collect request level metrics #4682
Draft
sourabh1007
wants to merge
13
commits into
master
Choose a base branch
from
users/sourabhjain/otelmetriccpu
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
FabianMeiswinkel and
kirillg
as code owners
September 13, 2024 02:52
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
September 13, 2024 02:55
c47f59b
to
6fc4195
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
2 times, most recently
from
September 16, 2024 02:30
f4c3132
to
512f1ed
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
4 times, most recently
from
September 26, 2024 13:52
6e89d3a
to
fb81cfa
Compare
sourabh1007
force-pushed
the
users/sourabhjain/otelmetriccpu
branch
from
September 30, 2024 05:37
c686b4d
to
320e618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR,
Added new flag in
CosmosClientTelemetryOptions
i.e.IsClientMetricsEnabled
, to enable/disable metrics. By default, it would be disabled. (inspired from Java SDK https://github.com/Azure/azure-sdk-for-java/blob/5bc07ca75c7c0520c1098b5a6264258b6e043435/sdk/cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosClientTelemetryConfig.java#L61)If Enabled, collecting below metrics:
With below dimensions,
refer. this for doumentation, https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/cosmos/azure-cosmos/docs/Metrics.md
Type of change