Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal] UnitTest: Adds Test to Validate Regions Type Public Fields #4730

Merged
merged 20 commits into from
Oct 2, 2024

Conversation

kirankumarkolli
Copy link
Member

@kirankumarkolli kirankumarkolli commented Sep 27, 2024

[INTERNAL] UnitTest: Regions type public fields validation

Broken for (Germany Central)  and (Germany Northeast).
Needs Direct package upgrade with the fix.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@kundadebdatta kundadebdatta changed the title [INTERNAL] UnitTest: Regions type public fields validation [Internal] UnitTest: Regions type public fields validation Sep 27, 2024
@kundadebdatta kundadebdatta changed the title [Internal] UnitTest: Regions type public fields validation [Internal] UnitTest: Adds Test to Validate Regions Type Public Fields Sep 27, 2024
kundadebdatta
kundadebdatta previously approved these changes Sep 27, 2024
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kundadebdatta
kundadebdatta previously approved these changes Sep 28, 2024
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kirankumarkolli kirankumarkolli enabled auto-merge (squash) September 30, 2024 16:12
@kirankumarkolli kirankumarkolli added the auto-merge Enables automation to merge PRs label Sep 30, 2024
…osClientOptionsUnitTests.cs

Co-authored-by: Kevin Pilch <[email protected]>
Pilchie
Pilchie previously approved these changes Oct 2, 2024
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirankumarkolli kirankumarkolli merged commit 62155aa into master Oct 2, 2024
21 checks passed
@kirankumarkolli kirankumarkolli deleted the users/kirankk/_preferred_regions_test branch October 2, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants