[Cosmos] Query Databases, Query Containers, and expand ContainerProperties to include all relevant properties #1843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analogrelay
requested review from
Pilchie,
kirankumarkolli,
tvaron3,
FabianMeiswinkel and
kundadebdatta
as code owners
Pilchie
approved these changes
Oct 10, 2024
heaths
approved these changes
Oct 10, 2024
sdk/cosmos/azure_data_cosmos/src/models/container_properties.rs
Outdated
Show resolved
Hide resolved
|
Added vector embedding stuff. While I don't need a reapproval, I wouldn't mind a quick second look @Pilchie . I'll probably just merge this in later today though, and we can always do a little tidy up afterwards if I missed something. I've verified the vector embedding deserialization against a test account. |
Pilchie
reviewed
Oct 14, 2024
sdk/cosmos/azure_data_cosmos/src/models/container_properties.rs
Outdated
Show resolved
Hide resolved
analogrelay
force-pushed
the
ashleyst/cosmos-other-db-container-apis
branch
from
671514e
to
6a45bed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the following new APIs:
CosmosClient::query_databasesto query across the databases in an accountDatabaseClient::query_containersto query across the containers in an accountTo do this, I was able to make a common
send_query_requestto our internalCosmosPipelinewrapper, which makes the individual query APIs fairly compact.In addition, I added missing properties to
ContainerProperties, based on the Go SDK. I also added Vector Indexing properties, which aren't currently in the Go SDK.I took another attempt at removing the
#[allow(unused_variables)]from ouroptionsparameters. As far as I can tell, there is no escaping it. If an impl is in the same crate as the trait it's implementing, the fact that the trait requires a parameter is not sufficient to suppress theunused_variableslint (see Playground). Annoying, but appears to be by-design, though I may follow up on the rust-lang users discourse board.