Support NO_PROXY environment variable and fix HTTP_PROXY/HTTPS_PROXY behaviour
#218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Currently there is support for
HTTP/HTTPS_PROXYbehaviour. But unfortunately not for theNO_PROXYenvironment variable.Faraday has native support for all the above parameters since 0.12 (https://github.com/lostisland/faraday/blob/main/CHANGELOG.md#v0120). So there is no need to configure it manually anymore.
I've update the tests so there are tests for the
NO_PROXYparameter, but also noticed there was a mistake in the tests. When onlyHTTP_PROXYis configured, then there should be no proxy being used forhttps://websites. This should be done by theHTTPS_PROXYparameter. I've updated the tests to correct this.