Postgres Function support added #2270
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Postgres Function support added
sanjeev23oct
requested review from
mbhaskar,
Aniruddh25,
seantleonard,
Mathos1432,
gledis69,
aaronburtle,
tarazou9,
ayush3797,
abhishekkumams,
aaronpowell,
severussundar,
ravishetye,
rohkhann,
neeraj-sharma2592 and
sourabh1007
as code owners
|
@microsoft-github-policy-service agree |
|
Thank you for your contribution , @sanjeev23oct. Can you fill out the PR description template with contextual info? Please also add tests for validating your changes, which will help us review. |
| @@ -128,12 +129,124 @@ protected override DatabaseTable GenerateDbTable(string schemaName, string table | |||
| } | |||
|
|
|||
| /// <summary> | |||
| /// Takes a string version of a MySql data type and returns its .NET common language runtime (CLR) counterpart | |||
| /// TODO: For MySql stored procedure support, this needs to be implemented. | |||
| /// Takes a string version of a PostgreSql data type and returns its .NET common language runtime (CLR) counterpart | |||
There was a problem hiding this comment.
If there are changes related to MySQL as well, can you move them in a separate PR?
Since, the PR title says it's for Postgres
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Postgres Function support added
Why make this change?
#syntax. e.g. Closes #XXWhat is this change?
How was this tested?
Sample Request(s)