-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing pagination properties #2404
base: main
Are you sure you want to change the base?
Conversation
Pull request was converted to draft
can user specify any of these properties as for example:
|
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to update to allow null for properties that are optional. That way dab validate
won't fail to validate config files that exclude those properties and prefer DAB defaults.
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
Co-authored-by: Sean Leonard <[email protected]>
"integer", | ||
"null" | ||
] | ||
"description": "Specifies the maximum size, in megabytes, of the database response allowed in a single result. If set to null, the default value is 158 MB.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is default value = 158 MB? Why not some power of 2 for e.g. 128 or 256?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one question out of curiosity.
/azp run |
Closes #2333
Overview
max-response-size-mb
source
Specifies the maximum size, in megabytes, of the database response allowed in a single result. This limit helps prevent large results (in size) from overwhelming the API.
max-page-size
source
Defines the maximum number of records that can be returned in a single page of results. This limit helps prevent large results (in rows) from overwhelming the API.
-1
(unlimited)default-page-size
source
Sets the default number of records returned in a single response when the result set exceeds this limit. When this limit is reached, a continuation token is provided to help users retrieve the next page.
-1
(same asmax-page-size
)