Hot Reload File IO -> React to 1 file change notification per file change #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… events trigger hot reload, we only act on the first event which has a differing filecontents. If no file changes have actually occurred, we shouldn't act on the file change notification. Additional add protection for reading file with read inent version read/write which was causing issues in some hot reload scenarios.
seantleonard
added
the
🔥Hot Reload
| return; | ||
| } | ||
|
|
||
| byte[] updatedRuntimeConfigFileHash = FileUtilities.ComputeHash(filePath: _fileWatcher.Path + "/" + _fileWatcher.Filter); |
There was a problem hiding this comment.
it will be good to add in the comments why we needed to computeHash
| using System.Text; | ||
| using System.Threading.Tasks; | ||
|
|
||
| namespace Azure.DataApiBuilder.Config.Utilities |
There was a problem hiding this comment.
can be added some class/method summary
| { | ||
| public static byte[] ComputeHash(string filePath) | ||
| { | ||
| int runCount = 1; |
There was a problem hiding this comment.
what is runCount here?
| { | ||
| int runCount = 1; | ||
|
|
||
| while (runCount < 4) |
| } | ||
| } | ||
|
|
||
| return new byte[20]; |
There was a problem hiding this comment.
why 20? can we something else?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why make this change?
What is this change?
How was this tested?
TBD