Tcgc/xml encoded name #1862
Open
Tcgc/xml encoded name #1862
+19
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
requested review from
lmazuel,
m-nash,
srnagar,
joheredi,
bterlson,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
All changed packages have been documented.
Show changes
|
| ); | ||
| // 1. Check xml name encoding | ||
| if (xmlNameDecorator.length > 0) { | ||
| return xmlNameDecorator[0].arguments["name"]; |
There was a problem hiding this comment.
So we're thinking that there really shouldnt be a case where encodedName is used with this decorator, right? We'll always return what's in @xml.name
|
You can try these changes here
|
|
as i mentioned in the meeting, please hold this fix until i get the design for serialization refactor in tcgc, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Azure/autorest.python#2914