Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence gcc -Wunused-function #381

Closed
wants to merge 2 commits into from
Closed

Silence gcc -Wunused-function #381

wants to merge 2 commits into from

Commits on Feb 2, 2024

  1. Silence gcc -Wunused-function 

    gcc on MacOS-ARM64  may error out with

/Users/runner/work/php-src/php-src/ext/hash/blake3/upstream_blake3/c/blake3_dispatch.c:112:5: error: unused function 'get_cpu_features' [-Werror,-Wunused-function]

full compiler log https://github.com/php/php-src/actions/runs/7762643678/job/21173438425?pr=13194

- the optimal fix would be to make sure get_cpu_features() is only compiled on platforms where it is used, but that would take more effort (have not investigated how much effort that would be)
    @divinity76
    divinity76 authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    e9b0456 View commit details
    Browse the repository at this point in the history

  2. forgot semicolon 

    tcc requires it?
    @divinity76
    divinity76 authored Feb 2, 2024
    Configuration menu
    Copy the full SHA
    f72d884 View commit details
    Browse the repository at this point in the history