Weak ref #15863
Weak ref #15863
Conversation
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
There was a problem hiding this comment.
This can be considered a kind of a breaking change to be honest.
This forces people to change their typescript target or their lib (just like you had to do for our typescript build).
This is also the reason our build failed.
The suggestion I have will resolve the issue to all other users, because it will remove the reference to WeakRef on our public declarations. I know it changes the types, but it might prevent a few complaints on the forum.
|
What is your suggestion? |
it's in the comment - use any as the type that is used with the function that is exposed in our declarations. or do soemthing like: type WeakRefBJS<T extends Function> = any;and then use this in the _remove function. This will force us to add the lib, which is fine, but will not expose the WeakRef usage. |
|
Makes sense! Thanks |
|
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
|
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/15863/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/15863/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/15863/merge#BCU1XR#0 |
|
WebGL2 visualization test reporter: |
|
Visualization tests for WebGPU (Experimental) |
No description provided.