Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS - run an update of dependencies, move to modern API #15867

Merged
merged 5 commits into from
Nov 22, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Nov 21, 2024

This will remove the annoying warnings when building some of the tools.

Note that the large amount of files changed is due to the updated dependency that doesn't support default import. Named exports are now being used, so this had to be changed for the entire framework. It's mostly changing everything from import styles from... to import * as styles from...

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

@RaananW RaananW marked this pull request as draft November 21, 2024 16:03
@RaananW
Copy link
Member Author

RaananW commented Nov 21, 2024

Moved to draft to test something, will reopen after I am done :-)

@RaananW RaananW marked this pull request as ready for review November 21, 2024 16:58
@bjsplat
Copy link
Collaborator

bjsplat commented Nov 21, 2024

Reviewer - this PR has made changes to one or more package.json files.

@RaananW RaananW merged commit 26ae13a into BabylonJS:master Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants