Add size parameter to scatter artist #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #26 Add `alpha` property to control alpha-value of scatter points * Add `alpha` property to `Scatter` class in `src/biaplotter/artists.py` - Initialize `alpha` property in `__init__` method - Update `draw` method to use `alpha` property - Add getter and setter for `alpha` property * Add functionality to set and get `alpha` property for scatter artist in `CanvasWidget` class in `src/biaplotter/plotter.py` - Add `alpha` property to `CanvasWidget` class - Update `active_artist` setter to handle `alpha` property * Add unit tests for `alpha` property in `Scatter` class in `src/biaplotter/_tests/test_artists.py` - Test initialization, setting, and usage of `alpha` property --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/BiAPoL/biaplotter/issues/26?shareId=df67f154-a9ed-4910-a0bd-40b60e78eacc).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
==========================================
+ Coverage 90.11% 90.66% +0.54%
==========================================
Files 7 7
Lines 597 621 +24
==========================================
+ Hits 538 563 +25
+ Misses 59 58 -1 ☔ View full report in Codecov by Sentry. |
This reverts commit 54dae5b.
|
This looks great, thanks @jo-mueller ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #28
Add a
sizeproperty to theScatterclass to control the size of each point in the scatter plot.Scatter Class:
sizeproperty that accepts a float or an array of floats.sizeproperty to 1.sizeproperty to 1 when new data is set.drawmethod to use thesizeproperty.Tests:
sizeproperty in thetest_scatterfunction.sizeproperty accepts a float and an array of floats.sizeproperty resets to a default value when new data is set.Documentation:
sizeproperty in theScatterclass.For more details, open the Copilot Workspace session.