Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up automatic deployment #304

Merged
merged 3 commits into from
Apr 23, 2024
Merged

Set up automatic deployment #304

merged 3 commits into from
Apr 23, 2024

Conversation

jo-mueller
Copy link
Collaborator

Fixes #299

This PR sets the correct API token for an automatic release through PyPi upon publishing a release on github. It also sets the latest versions for the involved github actions. It also uses the newer build functionality instead of the older bdist wheel etc.

I essentially copied the code from here

Copy link

codecov bot commented Jan 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e937dc) 77.24% compared to head (d858fb1) 77.24%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   77.24%   77.24%           
=======================================
  Files          16       16           
  Lines        1903     1903           
=======================================
  Hits         1470     1470           
  Misses        433      433           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Jan 22, 2024

Hey @jo-mueller,
again thanks for taking care of this. Shall I merge this before or after the next release is published?

@jo-mueller
Copy link
Collaborator Author

@Cryaaa yes, definitely. the next release should then go through automatically.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Jan 22, 2024

@Cryaaa yes, definitely. the next release should then go through automatically.

I'm not sure what you mean now :D just to confirm: merge this now and make the new release tag afterwards?

@jo-mueller
Copy link
Collaborator Author

@Cryaaa Yes, this should be merged before the next release. If everything is already set for the next release then the release can also go through where I am concerned.

@haesleinhuepf
Copy link
Member

make the new release tag afterwards?

Please do #300 #301 #302 #303 before releasing. Thanks

@Cryaaa
Copy link
Collaborator

Cryaaa commented Jan 23, 2024

make the new release tag afterwards?

Please do #300 #301 #302 #303 before releasing. Thanks

Yes I wasn’t planning on releasing before the testing and documentation!

@zoccoler zoccoler merged commit adff1c5 into main Apr 23, 2024
8 checks passed
@jo-mueller jo-mueller deleted the set-up-automatic-deployment branch April 23, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set up automatic release on PyPi
4 participants