Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc layer types #311

Merged
merged 6 commits into from
Apr 16, 2024
Merged

Update doc layer types #311

merged 6 commits into from
Apr 16, 2024

Conversation

zoccoler
Copy link
Collaborator

Here is my attempt to update the documentation and solve #301 .

2 particular points I would like some feedback:

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.20%. Comparing base (6d370c3) to head (b22e7bd).
Report is 3 commits behind head on main.

Files Patch % Lines
napari_clusters_plotter/_plotter.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #311      +/-   ##
==========================================
- Coverage   77.24%   77.20%   -0.05%     
==========================================
  Files          16       16              
  Lines        1903     1904       +1     
==========================================
  Hits         1470     1470              
- Misses        433      434       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Mar 28, 2024

@zoccoler,
First of all thank you so much for taking care of this I love the examples you’ve added, very cool! As for the tracking data maybe @stefanhahmann can add a small explanation as to how the features were extracted? I think it was done with mastodon and I believe most tracking datasets would be generated by Fiji plugins but I’m also not very familiar with python/napari alternatives

@zoccoler
Copy link
Collaborator Author

Hi Stefan @stefanhahmann ,
what do you think about the generation of the tracking data? Should I keep the description as it is?

@stefanhahmann
Copy link
Contributor

stefanhahmann commented Apr 15, 2024

Hi Stefan @stefanhahmann , what do you think about the generation of the tracking data? Should I keep the description as it is?

I would recommend link these Notebooks as well: https://github.com/BiAPoL/napari-clusters-plotter-example-notebooks/tree/main/notebooks/mastodon

They show how the example data that I have added can be reproduced starting from Mastodon project. I am a bit unsure, if the better place to link this is the readme.md (e.g. after this line: https://github.com/BiAPoL/napari-clusters-plotter/pull/311/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R168) or the example notebook for the tracking layer type (i.e. loading_tracking_data_example.ipynb). @zoccoler what do you think?

@zoccoler
Copy link
Collaborator Author

Thanks @stefanhahmann ! I added a link to the readme now with a brief explanation.

@Cryaaa
Copy link
Collaborator

Cryaaa commented Apr 16, 2024

Awesome, then I don't see any issues with merging this!

@Cryaaa Cryaaa merged commit b33a64c into main Apr 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants