Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a list of former members on the people page #772

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

albangaignard
Copy link
Contributor

@albangaignard albangaignard commented Jun 16, 2023

The idea is to add a boolean field for each people.

@albangaignard albangaignard marked this pull request as draft June 16, 2023 15:16
@sneumann
Copy link
Contributor

Hi, cool, that was quick!
just one brief comment: why Boolean ?
One could have active, alumni,dontshow, somethingelse
Controlling where/if a person is shown.
Yours, Steffen

@ivanmicetic
Copy link
Member

Hi, cool, that was quick! just one brief comment: why Boolean ? One could have active, alumni,dontshow, somethingelse Controlling where/if a person is shown. Yours, Steffen

You're right, we can implement the state of the person as an array of values and check for those. The priority now is to go through the list of people and tag them accordingly...

@sneumann
Copy link
Contributor

Using the one-liner for U in $(grep github_username *.md | cut -d : -f 3 | sort | uniq | tr -d " " ) ; do echo -n "$U " ; HEAD https://github.com/$U | head -1 ; done
I found christopherchild 404 Not Found has renamed/pulled the GitHub repo, or that is a typo.
Yours, Steffen

@ljgarcia
Copy link
Contributor

@albangaignard @ivanmicetic will we keep the boolean or will we go for an enumeration of possible states?

@ljgarcia
Copy link
Contributor

Using the one-liner for U in $(grep github_username *.md | cut -d : -f 3 | sort | uniq | tr -d " " ) ; do echo -n "$U " ; HEAD https://github.com/$U | head -1 ; done I found christopherchild 404 Not Found has renamed/pulled the GitHub repo, or that is a typo. Yours, Steffen

@sneumann I am not sure I understand where the error is. ChrisChild is how Chris Child is recorded in the Bioschemas GitHub pages while christopherchild is the corresponding GitHub username (which is included in the person profile page at https://bioschemas.org/people/ChrisChild)

@sneumann
Copy link
Contributor

https://github.com/christopherchild gives a 404, I think that user is gone or miss-spelled:
https://github.com/search?q=christopherchild&type=users

@ljgarcia
Copy link
Contributor

@albangaignard @ivanmicetic any news on this draft?

1 similar comment
@ljgarcia
Copy link
Contributor

@albangaignard @ivanmicetic any news on this draft?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants