Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightUp Fix #520

Closed
wants to merge 0 commits into from
Closed

LightUp Fix #520

wants to merge 0 commits into from

Conversation

rspacerr
Copy link
Collaborator

@rspacerr rspacerr commented Apr 3, 2023

Description

I'm still working on TreeTent fix but I figured I might as well get the LightUp fix out. Added support in Puzzle Creator and should be able to save files.

Closes #372

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (improvement to an already existing feature)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

I opened Puzzle Creator, selected LightUp with bounds of 7x7, placed a black tile and was able to successfully save the file.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (if applicable)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Copy link
Collaborator

@Corppet Corppet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your changes have a lot of merge conflicts. Please fix them.
Additionally, please be careful of what files you are pushing. There are 114 files changed in this PR and after a quick look, the majority of these files don't have any real changes (my guess is the IDE you're using has different line endings from what this project uses).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add Support for LightUp in Puzzle Creator
2 participants