-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fixes for the Thermometer Bug Fixes #794
Merged
Merged
Commits on Jan 26, 2024
-
Fixed Short Truth Table case rule bug (#707)
* Revert "Bugfix 549 (#682)" This reverts commit 5048ee6. * Case rule test fix (#705) Co-authored-by: Chase Grajeda <[email protected]> * Rapid fix for STT case rules Case rules broke at some point from legacy code or merge conflict. Provided is a quick fix in CaseRule and CaseRule_Generic * Revert "Revert "Bugfix 549 (#682)"" (#706) This reverts commit e9fe310. --------- Co-authored-by: Chase-Grajeda <[email protected]> Co-authored-by: Chase Grajeda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 653c816 - Browse repository at this point
Copy the full SHA 653c816View commit details
Commits on Jan 30, 2024
-
* Simplify rule names * Contradiction Test Suite * checkstyle * Update Exporter * Revert "Update Exporter" This reverts commit bae1a1f. * Case Rule Test Suite * Update SkyscrapersExporter.java * allow null transitions * Update TreeTransition.java * Direct Rule Test Suite * added tests pass * Update DirectRule.java Commenting out print statement --------- Co-authored-by: ThisMatt <[email protected]> Co-authored-by: ThisMatt <[email protected]> Co-authored-by: Chase Grajeda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 4608222 - Browse repository at this point
Copy the full SHA 4608222View commit details
Commits on Feb 7, 2024
-
Skyscrapers puzzle editor (#720)
* Fixed Short Truth Table case rule bug (#707) * Revert "Bugfix 549 (#682)" This reverts commit 5048ee6. * Case rule test fix (#705) Co-authored-by: Chase Grajeda <[email protected]> * Rapid fix for STT case rules Case rules broke at some point from legacy code or merge conflict. Provided is a quick fix in CaseRule and CaseRule_Generic * Revert "Revert "Bugfix 549 (#682)"" (#706) This reverts commit e9fe310. --------- Co-authored-by: Chase-Grajeda <[email protected]> Co-authored-by: Chase Grajeda <[email protected]> * Implementing Puzzle Editor Removing Extraneous TreeTent Code Allowing setting tile number * Allow for editing clues on all axies * Remove Extraneous Code Removed functionality required for TreeTent but unnecessary for Skyscrapers * Remove Extraneous Code * Clue Tile in Editor Editor now requires selecting the clue tile to edit clues Added images for the tiles * Merge branch 'dev' into skyscrapersPuzzleEditor * Checkstyle Requirement * Necessary Code * Allow for test functionality --------- Co-authored-by: Charles Tian <[email protected]> Co-authored-by: Chase-Grajeda <[email protected]> Co-authored-by: Chase Grajeda <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 80cb273 - Browse repository at this point
Copy the full SHA 80cb273View commit details
Commits on Feb 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c2ab8d9 - Browse repository at this point
Copy the full SHA c2ab8d9View commit details
Commits on Feb 14, 2024
-
Added the vial class which will be helpful for checking rules down the line
Configuration menu - View commit details
-
Copy full SHA for ca7de69 - Browse repository at this point
Copy the full SHA ca7de69View commit details
Commits on Feb 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8c4ebc8 - Browse repository at this point
Copy the full SHA 8c4ebc8View commit details -
Discontinuous Mercury Rule added
Added the Discontinuous Mercury contradiciton rule. Added variables to the ThermometerBoard class to keep track of the numbers on the perimiter of the board as well as accessors/setters for these variables. Rewrote a section of the Vials code to make sure cells are added correctly as well as added some accessor functions.
Configuration menu - View commit details
-
Copy full SHA for 07b85cd - Browse repository at this point
Copy the full SHA 07b85cdView commit details
Commits on Feb 21, 2024
-
* Create java-autoformat.yml * Setup Java * Run spotless on repository * Adding spotless dependency during build * Adding spotless dependency during build * Give permissions to run spotless * Syntax * Adding Debug Tag * Check for modified files Also removed debug tag * Automated Java code formatting changes * Test command syntax * Correctly Identify modified files * Test autoformatter * Test autoformatter * Test autoformatter * Debugging * Debugging * Change method for detecting changed files * Try building before calling spotless * Update java-autoformat.yml * Update java-autoformat.yml * Update java-autoformat.yml * Purposely bad formatting Purposely adding some bad formatting to see if the auto-formatter triggers * Update build.gradle Disabling Checkstyle in build so the auto-formatter can trigger * Update java-autoformat.yml Have auto-formatter trigger when more commits are added to a pull request * Debugging * Adding more awful formatting * Update java-autoformat.yml * Changing repo URL * Going back to checkout v1 * Trying URL change * Trying out using env * Trying this now...? * Introducing more horrible changes * Spotless formatting using google format v1.19.2 * Manual formatting fix * Automated Java code formatting changes * Different format type Trying to get it to pass checkstyle * Disable checkstyle temporarily * Automated Java code formatting changes * Default google formatting style * Automated Java code formatting changes * Comments and reordering styles * Adding extra newlines * Automated Java code formatting changes * Changing tabs from 2 to 4 spaces Supposedly the only difference that aosp makes is the 2 spaces? Hopefully it doesn't break anything else * Remove solo } requirement and reactivate checkstyle * Automated Java code formatting changes * Update checkstyle.xml Removed problematic LeftCurly and RightCurly requirements * Changing back to tabWidth * Add newline to test formatter + build * Automated Java code formatting changes * Trying some ChatGPT stuff * Getting rid of problematic experimentation --------- Co-authored-by: Bram van Heuveln <[email protected]> Co-authored-by: Charles Tian <[email protected]> Co-authored-by: charlestian23 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2190f7e - Browse repository at this point
Copy the full SHA 2190f7eView commit details -
* Fixed Short Truth Table case rule bug (#707) * Revert "Bugfix 549 (#682)" This reverts commit 5048ee6. * Case rule test fix (#705) Co-authored-by: Chase Grajeda <[email protected]> * Rapid fix for STT case rules Case rules broke at some point from legacy code or merge conflict. Provided is a quick fix in CaseRule and CaseRule_Generic * Revert "Revert "Bugfix 549 (#682)"" (#706) This reverts commit e9fe310. --------- Co-authored-by: Chase-Grajeda <[email protected]> Co-authored-by: Chase Grajeda <[email protected]> * Change Java version to 21 and setup JPackage to bundle Java with the app * Setup gradle action for java 21 * Fix distribution in gradle.yml * Fix java version in tests * Fix java distribution in tests * Add jpackage task * Add Linux to jpackage task * Fix jpackage task * Add java setup to jpackage tasks * Separate build into separate tasks for different operating systems * Fix mac jpackage not working and changed names of artifacts * Potential macos installer build fix * Potential macos installer build fix attempt 2 * Potential macos installer build fix attempt 3 * Add quotes around executable name for macos installer * Add logo and shortcut prompt * Update version in build.gradle * Make installer name different to app (It's a weird way to do it, it renames the file in a gradle task). * Update java-autoformat.yml Added check to make sure the pull request is not from a fork --------- Co-authored-by: Charles Tian <[email protected]> Co-authored-by: Chase-Grajeda <[email protected]> Co-authored-by: Chase Grajeda <[email protected]> Co-authored-by: charlestian23 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for b1e2f93 - Browse repository at this point
Copy the full SHA b1e2f93View commit details -
Configuration menu - View commit details
-
Copy full SHA for ea6df89 - Browse repository at this point
Copy the full SHA ea6df89View commit details -
* Update build.gradle Fixing the deprecation issues in the autoformatter * Update build.gradle * Update build.gradle * Update to use Java 21 * Automated Java code formatting changes --------- Co-authored-by: Bram van Heuveln <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 2b036c0 - Browse repository at this point
Copy the full SHA 2b036c0View commit details -
Changing to 6.0.0 since Java upgrade may break backwards compatibility
Configuration menu - View commit details
-
Copy full SHA for 5189a0b - Browse repository at this point
Copy the full SHA 5189a0bView commit details
Commits on Feb 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 898add4 - Browse repository at this point
Copy the full SHA 898add4View commit details -
Configuration menu - View commit details
-
Copy full SHA for e03c923 - Browse repository at this point
Copy the full SHA e03c923View commit details
Commits on Feb 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 32371ed - Browse repository at this point
Copy the full SHA 32371edView commit details
Commits on Feb 27, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 678da44 - Browse repository at this point
Copy the full SHA 678da44View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1e738a - Browse repository at this point
Copy the full SHA b1e738aView commit details
Commits on Mar 1, 2024
-
First draft of the importer written and setData refactored
Configuration menu - View commit details
-
Copy full SHA for caeeef4 - Browse repository at this point
Copy the full SHA caeeef4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 43d1305 - Browse repository at this point
Copy the full SHA 43d1305View commit details
Commits on Mar 12, 2024
-
Added Puzzle Factory and Importer
Refactored a bunch of code so we now (in theory) import correctly
Configuration menu - View commit details
-
Copy full SHA for cd124ea - Browse repository at this point
Copy the full SHA cd124eaView commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e952533 - Browse repository at this point
Copy the full SHA e952533View commit details -
Configuration menu - View commit details
-
Copy full SHA for fea9223 - Browse repository at this point
Copy the full SHA fea9223View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20a4b4d - Browse repository at this point
Copy the full SHA 20a4b4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for cce8ee5 - Browse repository at this point
Copy the full SHA cce8ee5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fdc396 - Browse repository at this point
Copy the full SHA 1fdc396View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9fc1f5 - Browse repository at this point
Copy the full SHA f9fc1f5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 744df30 - Browse repository at this point
Copy the full SHA 744df30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 68b4f20 - Browse repository at this point
Copy the full SHA 68b4f20View commit details
Commits on Mar 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a62ec86 - Browse repository at this point
Copy the full SHA a62ec86View commit details -
Configuration menu - View commit details
-
Copy full SHA for d285afa - Browse repository at this point
Copy the full SHA d285afaView commit details -
Further work on getting a file to open without errors
Configuration menu - View commit details
-
Copy full SHA for cba0779 - Browse repository at this point
Copy the full SHA cba0779View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0771835 - Browse repository at this point
Copy the full SHA 0771835View commit details
Commits on Mar 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ae7359c - Browse repository at this point
Copy the full SHA ae7359cView commit details
Commits on Mar 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c74d877 - Browse repository at this point
Copy the full SHA c74d877View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7f906a - Browse repository at this point
Copy the full SHA b7f906aView commit details
Commits on Mar 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9e2955f - Browse repository at this point
Copy the full SHA 9e2955fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3adeea9 - Browse repository at this point
Copy the full SHA 3adeea9View commit details -
Configuration menu - View commit details
-
Copy full SHA for af47353 - Browse repository at this point
Copy the full SHA af47353View commit details -
Configuration menu - View commit details
-
Copy full SHA for 024778a - Browse repository at this point
Copy the full SHA 024778aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8a0109b - Browse repository at this point
Copy the full SHA 8a0109bView commit details
Commits on Mar 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f0d07af - Browse repository at this point
Copy the full SHA f0d07afView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a3aae6 - Browse repository at this point
Copy the full SHA 2a3aae6View commit details
Commits on Apr 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 997b7b4 - Browse repository at this point
Copy the full SHA 997b7b4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9f9a4b - Browse repository at this point
Copy the full SHA d9f9a4bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.