Sudoku #805
Merged
Sudoku #805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored Case Rules to match wiki description and fixed bug that only checked regions and not all group types.
Refactoring and bug fixes
Trying again since there was a merge issue last time.
Updated PossibleCellsForNumber to display number values when case board is clicked and generate proper case boards based off number chosen and local region.
Added and bug tested two alternate versions of the region based Possible Cells For Number case rule.
Created and applied formatted images to case rules to help better show how case rule functions.
Last Cell for Number Direct Rule was almost completely re-written to improve functionality and minimize playing errors.
LastNumberForCell allowed any number to go into a cell if the cell only had one option for number. I.e if the last option was 9 you could put any number 1-9 in cell, this patch fixed that error
PossibleCellForNumber Case rule was only generating branches for and as the value 1 and no other values. Repeated Numbers Case rule was always triggering contradiction since it was taking the empty tile value of 0 in to account with other numbers.
Unfinished but pushing
added code that might work
Reformatted NoCellForNumber to function completely in all tested cases.
If statements missing brackets were causing build errors, this should fix that.
+2 new contradiction rule Change old contradiction rule numbering to reflect as such
changed the order and reference sheet to reflect that
Made and added images for new contradiciton rules. Also refactored NoCellForNumber rule to NoCellForNumberRegion.
It wasn't doing anything and was always returning true.
Fake tests added
Fake tests was bad
Basic Last Number for Cell test case.
Implemented 2 new test cases for LastNumberForCell and made Class and Test Case for RepeatedNumber contradiction rule
Added another test for RepeatedNumbers contradiction rule and fixed previous error.
its forcing me to do this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #(issue)
Type of change
How Has This Been Tested?
Checklist: