CI: include CPU arch in release assets names #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfbao
commented
Jul 20, 2023
| @@ -112,12 +112,12 @@ jobs: | |||
| working-directory: src/D2L.Bmx/build | |||
| run: | | |||
| if ($env:PLATFORM -eq 'win') { | |||
| Compress-Archive -Path "bmx.exe" -DestinationPath "bmx-win.zip" | |||
| gh release upload "$env:RELEASE_TAG" "bmx-win.zip" | |||
| Compress-Archive -Path "bmx.exe" -DestinationPath "bmx-win-x64.zip" | |||
There was a problem hiding this comment.
decided against x86-64 because the hyphen can be confusing.
also .NET uses x64 in RIDs.
cfbao
requested review from
jharoutuniand2l,
scowing,
boarnoah,
gord5500 and
DannyDaoBoYang
as code owners
gord5500
approved these changes
Jul 20, 2023
jharoutuniand2l
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In the future we'll likely want to add ARM builds, and it'd be good to not break the naming pattern (and existing automated processes) when we do.