wipes profile section when bmx write --use-credential-process is ran #447
Conversation
jkomonen
requested review from
cfbao,
boarnoah,
scowing,
jharoutuniand2l and
gord5500
|
PR #448 created to format .cs files. |
src/D2L.Bmx/WriteHandler.cs
Outdated
| var defaultCredentialsFile = parser.ReadFile( SharedCredentialsFile.DefaultFilePath ); | ||
| if (defaultCredentialsFile.Sections.ContainsSection( profile ) ) { | ||
| defaultCredentialsFile.Sections.RemoveSection( profile ); | ||
| parser.WriteFile(SharedCredentialsFile.DefaultFilePath, defaultCredentialsFile); |
There was a problem hiding this comment.
Formatting looks off here.
Please check the auto formatting setup in your IDE and make sure it respects editorconfig. Let us know if you need any help with that.
|
PR #449 created to format .cs files. |
|
PR #450 created to format .cs files. |
Where can I find the documentation to set this up? |
|
Here: https://desire2learn.atlassian.net/wiki/spaces/MaT/pages/1470857332/IDE+setup+and+auto+formatting Aside, please @ people in GitHub when you're "replying" on the main PR conversation thread, because otherwise we won't get a direct notification. |
Why
If there's a profile with the same name in the credentials and config file, it will default to the credentials file, so you will eventually get invalid credentials
Ticket
https://desire2learn.atlassian.net/browse/VUL-329