Remove qoutes from invoke via AWS Credential Process #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reported-by: Chenfeng Bao <[email protected]>
boarnoah
requested review from
cfbao,
scowing,
jharoutuniand2l,
jkomonen and
gord5500
gord5500
approved these changes
Jun 13, 2024
cfbao
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
@cfbao noticed that the various AWS SDK's handle invoking applications used by credential_process differently. In the case of the Go SDK that includes, invoking BMX verbatim, including qoutes and all.
There isn't a need to quote any of these fields to handle white spaces (username, okta subdomain, aws role name, or assume duration etc...)