write: update config file section with same name if no cred process flag #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gord5500
requested review from
cfbao,
boarnoah,
scowing,
jharoutuniand2l and
jkomonen
cfbao
reviewed
Jun 17, 2024
src/D2L.Bmx/WriteHandler.cs
Outdated
| @@ -85,6 +85,27 @@ bool useCredentialProcess | |||
| + $" --role {awsCredsInfo.Role}" | |||
| + $" --duration {awsCredsInfo.Duration}"; | |||
| } else { | |||
| if( File.Exists( SharedCredentialsFile.DefaultConfigFilePath ) ) { | |||
| string profileName = $"profile {profile}"; | |||
There was a problem hiding this comment.
nit: it's really the section name rather than profile name
Suggested change
| string profileName = $"profile {profile}"; | |
| string sectionName = $"profile {profile}"; |
There was a problem hiding this comment.
I feel like there's an opportunity to refactor and dedupe some logic and declarations in this whole "write" area. It's getting a bit messy now. But we can do it another time.
There was a problem hiding this comment.
Specifically the section removing part or something else?
There was a problem hiding this comment.
everything about handling AWS creds and config files
Co-authored-by: Chenfeng Bao <[email protected]>
cfbao
approved these changes
Jun 18, 2024
cfbao
added a commit
that referenced
this pull request
Jun 24, 2024
follow up to this comment: #453 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Default credentials file takes priority over the default config which is where we store profiles using
credential_process. If someone had an existing profile in config file and then runsbmx write, creds will be stored into the default credentials file making the existing one useless. We should remove the existing key in the config file so there is no confusion.credential_processis the better way for majority of people but there are some scenarios where it's not supported. So we are leaving some information to the user that it is no longer being used. Just in case they unintentionally ran write without the flag. Not going with a prompt to confirm because that could break existing scriptsTicket
VUL-385