Added stop feature #103
Merged
Added stop feature #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steve8708
reviewed
Feb 2, 2024
src/helpers/completion.ts
Outdated
| rl.input.setRawMode(true); | ||
|
|
||
| rl.input.on('keypress', (key) => { | ||
| if (typeof key === 'string' && key.toLowerCase().includes('q')) { |
There was a problem hiding this comment.
this is a great idea. can/should we support the esc key as well? or is that not possible. i'm guessing most users will intuitively hit esc when wanting to stop the stream, so if that works as well it could be a nice addition
|
@steve8708 Added the escape key to stop the stream. Any what's your thoughts on this? |
|
Looks great, will get this release soon, thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a stop feature as requested on issue #79. By pressing 'q' the response in "ai chat" stops.