Added Directory Exclusion #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recursive directory exclusion added
|
Preparing review... |
steve8708
reviewed
Nov 21, 2023
| // Iterate over each directory in the exclude array of the config object | ||
| for (const dir of config.exclude) { | ||
| // If the URL contains the current directory, return false | ||
| if (url.includes(dir)) { |
There was a problem hiding this comment.
for consistency sake, can we make these glob expressions? similar to include. we can use minimatch for testing against it
ollieanwyll
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recursive directory exclusion (#9) and user configurable through config.ts. A list of excluded parent directories is read into an array to be checked against during the crawling process and skipped if found. Pretty quick and dirty and could probably use some optimization.
Tidied up some related comments as well to make things a little clearer.