Added x-frame-options verification to graphql api #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Betree
reviewed
Apr 11, 2021
There was a problem hiding this comment.
Looks good to me. My main concern is that this endpoint can easily be used to SPAM a random URL, there's no rate limiting. I'll add additional feedback in CaptainFact/captain-fact-frontend#765
Comment on lines
+33
to
+36
| case String.match?(value, ~r/deny|sameorigin/i) do | ||
| true -> {:ok, false} | ||
| false -> {:ok, true} | ||
| end |
There was a problem hiding this comment.
Personal preference, not a request change
Suggested change
| case String.match?(value, ~r/deny|sameorigin/i) do | |
| true -> {:ok, false} | |
| false -> {:ok, true} | |
| end | |
| {:ok, !String.match?(value, ~r/deny|sameorigin/i)} |
Betree
force-pushed
the
staging
branch
6 times, most recently
from
8edadfd
to
a2007b8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CaptainFact/captain-fact-frontend#765