Add pre/postinstall scripts to prevent 'npm install' failure #16454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of github.com:CartoDB/cartodb into feature/sc-172043/reef-admin-can-t-set-map-to-private
…f-4096-named-maps
…anges-not-applying
…an-t-set-map-to-private
…of github.com:CartoDB/cartodb into feature/sc-172043/reef-admin-can-t-set-map-to-private
…an-t-set-map-to-private
[sc95788] Fix 404.html page
…-randomly-2 Log pg_locks when there is a timeout during a sync table importation
* increase cloud build timeout * increase timeout * downgrade rubocop version * Update rubocop.yml * rubocop 1.17.0 * Update rubocop.yml * revert version
…sers-delete-themselves
…ities-when-users-delete-themselves [sc230232] Avoid deleting a user if it has shared entities
…ion-notes-to-cartodb-repository
VictorVelarde
suggested changes
May 15, 2024
|
PR was created on top of |
|
If this goes against cloud-native branch, just for our do-catalog bundle, I'm fine with it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR;
Just fix the
npm installscriptExplanation
The recommended Node Version for this repository is
10.15.1, which uses npm6.4.1under the hood (see.nvmrc).When trying to install dependencies directly from Git repositories, this version of NPM uses internally the git: protocol, which performs operations such as:
/usr/bin/git ls-remote -h -t git://github.com/<organization>/<repository>.gitgit clone --depth=1 -q -b master git://github.com/<organization>/<repository>.git <some-cache-directory>However, Github dropped support for this protocol a while ago, hence
npm installfails always.The less elegant, but most pragmatic solution @Josmorsot and I found during the journey is to redirect every
git:protocol request throughhttps:by modifying the NPM configuration locally