use a single transaction for each generation when importing data from a file #18606
+24
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
the
Changed
arvidn
approved these changes
Sep 19, 2024
|
perhaps I jumped the gun; but it would be nice to have some rationale in the description. did you measure any difference? |
|
I did, and was discussing with Earle. (or sending messages to be discussed when they wake up |
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Improve runtime of insertion to the datalayer db from dat files. This occurs when syncing a new update, for example.
many transactions - full file: 3.6s
one transaction - full file: 2.2s
many transactions - delta file: 0.97s
one transaction - delta file: 0.49s
Current Behavior:
New Behavior:
Testing Notes: