Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHIA-1472 Augment get_mirror_info to accept both types of programs #18637

Merged

Conversation

AmineKhaldi
Copy link
Contributor

Purpose:

This allows us to use serialized programs without the need to convert them into programs.

Current Behavior:

We would need to convert serialized programs to programs before using the function.

New Behavior:

We no longer need to convert serialized programs into programs before using the function.

@AmineKhaldi AmineKhaldi added Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup labels Sep 25, 2024
@AmineKhaldi AmineKhaldi self-assigned this Sep 25, 2024
This allows us to use serialized programs without the need to convert them into programs.
Copy link

Pull Request Test Coverage Report for Build 11053271276

Details

  • 5 of 5 (100.0%) changed or added relevant lines in 2 files are covered.
  • 11 unchanged lines in 8 files lost coverage.
  • Overall coverage increased (+0.03%) to 90.969%

Files with Coverage Reduction New Missed Lines %
chia/daemon/keychain_proxy.py 1 73.03%
chia/rpc/rpc_server.py 1 87.83%
chia/farmer/farmer.py 1 72.27%
chia/_tests/core/full_node/test_transactions.py 1 99.14%
chia/wallet/util/wallet_sync_utils.py 1 86.54%
chia/daemon/client.py 1 73.33%
chia/_tests/core/test_farmer_harvester_rpc.py 2 98.02%
chia/wallet/wallet_node.py 3 88.15%
Totals Coverage Status
Change from base Build 11053045680: 0.03%
Covered Lines: 102046
Relevant Lines: 112152

💛 - Coveralls

@AmineKhaldi AmineKhaldi marked this pull request as ready for review October 2, 2024 15:26
@AmineKhaldi AmineKhaldi requested a review from a team as a code owner October 2, 2024 15:26
@Starttoaster Starttoaster merged commit 40e0df2 into Chia-Network:main Oct 3, 2024
367 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changed Required label for PR that categorizes merge commit message as "Changed" for changelog Cleanup Code cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants