CHIA-1525 Make PreValidationResult take SpendBundleConditions instead of NPCResult #18647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
Changed
AmineKhaldi
force-pushed
the
prevalidationresults_take_spendbundleconditions
branch
2 times, most recently
from
44b7508
to
0f7d0e7
Compare
Pull Request Test Coverage Report for Build 11106596781Details
💛 - Coveralls |
arvidn
reviewed
Sep 30, 2024
| @@ -125,12 +124,12 @@ async def validate_block_body( | |||
| get_coin_records: Callable[[Collection[bytes32]], Awaitable[List[CoinRecord]]], | |||
| block: Union[FullBlock, UnfinishedBlock], | |||
| height: uint32, | |||
| npc_result: Optional[NPCResult], | |||
| conds: Optional[SpendBundleConditions], | |||
There was a problem hiding this comment.
the documentation of this function, below, should be updated as well. and it should say that this must be set for transaction blocks and must be None for non-transaction blocks
AmineKhaldi
force-pushed
the
prevalidationresults_take_spendbundleconditions
branch
from
0f7d0e7
to
223d5ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
PreValidationResultcurrently usesNPCResultwithout error possibility in this context, so it's simpler to useSpendBundleConditionsdirectly here.Current Behavior:
PreValidationResultholdsNPCResultand its users have logic to get toSpendBundleConditionsfrom there.New Behavior:
PreValidationResultholdsSpendBundleConditionsand its users simply leverage that without needing extra logic.