[CHIA-1308] Port wallet node RPC endpoints to @marshal decorator
#18651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quexington
added
Changed
Quexington
force-pushed
the
quex.port_wallet_node_endpoints_to_marshal
branch
from
420fb7f
to
cc17b41
Compare
Quexington
force-pushed
the
quex.port_wallet_node_endpoints_to_marshal
branch
from
646912e
to
5dc8efd
Compare
altendky
requested changes
Sep 30, 2024
| @@ -292,7 +298,10 @@ class PushTransactionsCMD: | |||
|
|
|||
| async def run(self) -> None: | |||
| async with self.rpc_info.wallet_rpc() as wallet_rpc: | |||
| await wallet_rpc.client.push_transactions(self.txs_in.transaction_bundle.txs) | |||
| # TODO: no default here | |||
There was a problem hiding this comment.
hmm? not clear if this is for later or now or what the needed action is
| @@ -694,20 +693,23 @@ async def push_transactions( | |||
|
|
|||
| interface.side_effects.transactions.extend(inner_action_scope.side_effects.transactions) | |||
|
|
|||
| return {} | |||
| return PushTransactionsResponse([], []) # tx_endpoint takes care of this | |||
There was a problem hiding this comment.
seems fishy to need this if it's pointless?
| resp = await client.fetch( | ||
| "push_transactions", {"transactions": [tx.to_json_dict_convenience(wallet_node.config)], "fee": 10} | ||
| ) | ||
| assert resp["success"] | ||
| resp = await client.fetch("push_transactions", {"transactions": [tx.to_json_dict()], "fee": 10}) | ||
| resp = await client.fetch("push_transactions", {"transactions": [bytes(tx).hex()], "fee": 10}) |
There was a problem hiding this comment.
are we changing the api? or did tx.to_json_dict() create a string before?
| @@ -513,8 +518,8 @@ async def test_get_timestamp_for_height(wallet_rpc_environment: WalletRpcTestEnv | |||
|
|
|||
| await generate_funds(full_node_api, env.wallet_1) | |||
|
|
|||
| # This tests that the client returns a uint64, rather than raising or returning something unexpected | |||
| uint64(await client.get_timestamp_for_height(uint32(1))) | |||
| # This tests that the client returns a sucessfully, rather than raising or returning something unexpected | |||
There was a problem hiding this comment.
Suggested change
| # This tests that the client returns a sucessfully, rather than raising or returning something unexpected | |
| # This tests that the client returns successfully, rather than raising or returning something unexpected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another PR in the same vein as #18593 .