Enhancement: Use github actions to build the cluster_layer.zip artifacts for end users #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed pycryptodome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In TAC (Cisco CX) org we have seen cases where customers are trying and struggling to build the
cluster_layer.zip. This has been compounded by AWS lamdba functionsglibclibraries deviating from a standard ubuntu release (18.04). It has caused issues like this.I suggest that we use github actions to do the steps necessary to build the
cluster_layer.zipand publish them in a github release. The end user then just needs to download the artifact, modify theConfiguration.jsonfile and then upload the artifacts to the S3 bucket per the instructions.Included in the repo is a github action that will build a
cluster_aws.zipfile that includescluster_layer.zip,cluster_manager.zipandcluster_lifecycle.zip. Also included is an updated readme in thecluster/awsfolder that clarifies the necessary steps.Ideally, the repo should provide all these artifacts for each of the deployment scenarios and environments rather than expecting the end user to build them.