Uses Libgit2sharp to clone repos. Fixes #29 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer downloads and unzips a zip file. Also cleans up the code in UploadController a little.
|
Not sure if Libgit2sharp supports, but consider only clone the actual commit and not the whole repo (including history): |
|
Good idea @yannisgu, I've posted on libgit2sharp issue about shallow clones where two other people showed interest in implementing it in libgit2 (more links in my comment @ libgit2sharp) |
| @@ -24,14 +25,20 @@ public ActionResult Submit(string githubUrl) | |||
| var retriever = new GitHubRetriever(githubUrl); | |||
| if (!retriever.IsValidUrl()) | |||
| { | |||
| // TODO: Return error | |||
| ViewBag.Error = "Invalid GitHub repository. Please try another"; | |||
| ViewBag.Error = "Make sure that the provided path is valid."; | |||
There was a problem hiding this comment.
I think the message should indicate this has to be a GitHub repository.
JoshVarty
added a commit
that referenced
this pull request
Dec 1, 2014
Uses Libgit2sharp to clone repos. Fixes #29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer downloads and unzips a zip file.
This fixes the issue with path being too long (#29)
Also cleans up the code in UploadController a little.