Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark @/commons-ui/core components as client only for now #880

Merged
merged 9 commits into from
Sep 9, 2024
Merged

Mark @/commons-ui/core components as client only for now #880

merged 9 commits into from
Sep 9, 2024

Conversation

kilemensi
Copy link
Member

@kilemensi kilemensi commented Sep 6, 2024 •
edited
Loading

Description

Seems like most of @mui/material components are client only for now.

NOTE: I'll leave #878 up for now to keep track of progress made by @mui/material components

Type of change

  • Chore

Screenshots

Screenshot 2024-09-06 at 16 57 20

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Sep 6, 2024
@kilemensi kilemensi self-assigned this Sep 6, 2024
@kilemensi kilemensi requested a review from a team September 6, 2024 13:59
@kilemensi kilemensi added this pull request to the merge queue Sep 9, 2024
Merged via the queue into main with commit 32c6c97 Sep 9, 2024
4 checks passed
@kilemensi kilemensi deleted the fix/commons_ui_core_client branch September 9, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m453h m453h m453h approved these changes

@kelvinkipruto kelvinkipruto kelvinkipruto approved these changes

Assignees

@kilemensi kilemensi

Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
COMMONS
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kilemensi @m453h @kelvinkipruto