Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interstitial tag support Mamba 2.0 #145

Merged
merged 10 commits into from
Nov 1, 2024
Merged

Conversation

rmigneco
Copy link
Collaborator

@rmigneco rmigneco commented Nov 1, 2024

Description

This PR adds support for Interstitial Tag Attributes as outlined in the Appendix D of the HLS Spec

Note - this is a port of the work from #144 but updated for Mamba 2.0 syntax

Change Notes

  • Adds PantosValue attributes to support interstitials
  • Updates the EXT_X_DATERANGETagValidator to include additional values and include specific validation rules for HLS Interstitials
  • Adds unit tests for the new validation rules
  • Creates HLSInterstitialValues to represent the attribute options
  • Creates InterstitialTagBuilder which facilitates creating a HLSTag type configured specifically for interstitials
  • Unit tests for InterstitialTagBuilder

Pre-submission Checklist

  • I ran the unit tests locally before checking in.
  • I made sure there were no compiler warnings before checking in.
  • I have written useful documentation for all public code.
  • I have written unit tests for this new feature.

@rmigneco rmigneco added the mamba2.0 A marker for features/bug fixes for a new version of mamba label Nov 1, 2024
@rmigneco rmigneco merged commit 7f7870c into develop Nov 1, 2024
4 checks passed
@rmigneco rmigneco deleted the interstitial-tag-support-2.0 branch November 1, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mamba2.0 A marker for features/bug fixes for a new version of mamba
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants