Rename synchronization service, split generic code and specific defaults #4
Annotations
1 error and 10 warnings
|
Run phpmd
Process completed with exit code 2.
|
|
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L33
The class NewSynchronizationService has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L38
Avoid excessively long variable names like $synchronizationService. Keep variable name length under 20.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L39
Avoid excessively long variable names like $synchronizationLogger. Keep variable name length under 20.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L61
The method synchronizeFromSource() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L61
The method synchronizeFromSource() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L61
The method synchronizeFromSource has a boolean flag argument $unsafe, which is a certain sign of a Single Responsibility Principle violation.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L74
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L107
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
|
Run phpmd:
src/Service/NewSynchronizationService.php#L127
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
Loading