Fix notifications, add contact details to rol #49
rjzondervanAnnotations
1 error and 11 warnings
|
build
Process completed with exit code 2.
|
|
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
|
build:
src/Service/NewSynchronizationService.php#L35
The class NewSynchronizationService has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13.
|
|
build:
src/Service/NewSynchronizationService.php#L55
Avoid excessively long variable names like $synchronizationLogger. Keep variable name length under 20.
|
|
build:
src/Service/NewSynchronizationService.php#L79
The method synchronizeFromSource() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
|
|
build:
src/Service/NewSynchronizationService.php#L79
The method synchronizeFromSource has a boolean flag argument $unsafe, which is a certain sign of a Single Responsibility Principle violation.
|
|
build:
src/Service/NewSynchronizationService.php#L79
Avoid unused parameters such as '$unsafe'.
|
|
build:
src/Service/NewSynchronizationService.php#L93
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
|
build:
src/Service/NewSynchronizationService.php#L128
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
|
build:
src/Service/NewSynchronizationService.php#L151
The method synchronizeFromSource uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
|
|
build:
src/Service/NewSynchronizationService.php#L199
The method synchronizeCollectionHandler() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
|
|
build:
src/Service/VrijBrpService.php#L82
Avoid unused parameters such as '$config'.
|