* update linting

client/.eslintrc.cjs

@@ -20,6 +20,7 @@ module.exports = {
     parser: '@typescript-eslint/parser'
   },
   rules: {
+    '@typescript-eslint/consistent-type-imports': ['error'],
     '@typescript-eslint/no-unused-vars': ['off'],
     '@typescript-eslint/no-unsafe-assignment': ['off'],
     'vue/multi-word-component-names': ['off'],

client/src/components/lobby/Options.vue

@@ -121,7 +121,7 @@ import { useGameStore } from '@/stores/game.js';
 import { mapState } from 'pinia';
 import { defineComponent } from 'vue';
 
-import { SettableOptions } from ':common/options';
+import type { SettableOptions } from ':common/options';
 
 type NumericKeyOfOptions = {
   [K in keyof SettableOptions]: SettableOptions[K] extends number ? K : never;

client/src/components/lobby/PlayerCard.vue

@@ -6,7 +6,7 @@
 
 <script lang="ts">
 import { defineComponent, type PropType } from 'vue';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 export default defineComponent({
   props: {

client/src/components/lobby/PlayerList.vue

@@ -14,7 +14,7 @@ import PlayerCard from '@/components/lobby/PlayerCard.vue';
 import { useRoomStore } from '@/stores/room.js';
 import { mapState } from 'pinia';
 import { defineComponent } from 'vue';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 export default defineComponent({
   components: {

client/src/components/responseMatching/MatchingSummary.vue

@@ -45,7 +45,7 @@ import { useRoomStore } from '@/stores/room.js';
 import { useGameStore } from '@/stores/game.js';
 import { mapState } from 'pinia';
 import { defineComponent } from 'vue';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 const click = new AudioWrap(ClickMp3);
 

client/src/directives/tooltip.ts

@@ -1,4 +1,5 @@
-import { DirectiveBinding, nextTick } from 'vue';
+import type { DirectiveBinding } from 'vue';
+import { nextTick } from 'vue';
 import { Tooltip } from 'bootstrap';
 import { useSettingsStore } from '@/stores/settings.js';
 

client/src/router/index.ts

@@ -1,4 +1,5 @@
-import { createWebHistory, createRouter, RouteLocation } from 'vue-router';
+import type { RouteLocation } from 'vue-router';
+import { createWebHistory, createRouter } from 'vue-router';
 import Home from '@/views/Home.vue';
 const Game = () => import('@/views/Game.vue');
 const About = () => import('@/views/About.vue');

client/src/socket/socket.ts

@@ -1,5 +1,5 @@
 import io from 'socket.io-client';
-import { TypedClientSocket } from ':common/socketioTypes';
+import type { TypedClientSocket } from ':common/socketioTypes';
 
 let socket: TypedClientSocket;
 if (process.env.NODE_ENV !== 'production') {

client/src/stores/game.ts

@@ -3,7 +3,7 @@
 import socket from '@/socket/socket.js';
 import { useRoomStore } from '@/stores/room.js';
 import { defineStore } from 'pinia';
-import {
+import type {
   Player,
   Match as ServerMatch,
   PollName,
@@ -12,8 +12,10 @@ import {
   Responses,
   MidgameConnectData
 } from ':common/stateTypes';
-import { defaultOptions, Options, VisibleOptions } from ':common/options';
-import { isOk, isSuccess, Result } from ':common/result';
+import type { Options, VisibleOptions } from ':common/options';
+import { defaultOptions } from ':common/options';
+import type { Result } from ':common/result';
+import { isOk } from ':common/result';
 
 type Scene =
   | 'lobby'

client/src/stores/room.ts

@@ -2,7 +2,7 @@
 import router from '@/router/index.js';
 import socket from '@/socket/socket.js';
 import { defineStore } from 'pinia';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 interface State {
   players: Player[];

client/src/types/shims-vue.d.ts

@@ -1,7 +1,7 @@
 // noinspection JSUnusedGlobalSymbols
 
 declare module '*.vue' {
-  import { defineComponent } from 'vue';
+  import type { defineComponent } from 'vue';
   const Component: ReturnType<typeof defineComponent>;
   export default Component;
 }

client/src/types/vue-i18n.d.ts

@@ -2,7 +2,7 @@
  * you need to import the some interfaces
  */
 import { DefineLocaleMessage, DefineDateTimeFormat, DefineNumberFormat } from 'vue-i18n';
-import en from '@/locales/en';
+import type en from '@/locales/en';
 
 type LocaleMessage = typeof en;
 

server/.eslintrc.cjs

@@ -15,6 +15,7 @@ module.exports = {
   },
   plugins: ['@typescript-eslint', 'prettier'],
   rules: {
+    '@typescript-eslint/consistent-type-imports': ['error'],
     'prettier/prettier': 2
   },
   ignorePatterns: ['/*', '!/src', '!/tests']

server/src/index.ts

@@ -3,7 +3,8 @@
 /**
  * Module dependencies.
  */
-import express, { Express, Request, Response } from 'express';
+import type { Express, Request, Response } from 'express';
+import express from 'express';
 
 import cors from 'cors';
 import path from 'path';
@@ -48,7 +49,8 @@ const server = http.createServer(app);
  * Create socket server
  */
 
-import { TypedServer, TypedSocket } from ':common/socketioTypes';
+import type { TypedSocket } from ':common/socketioTypes';
+import { TypedServer } from ':common/socketioTypes';
 const io = new TypedServer(server, {
   cors: {
     origin: ['http://localhost:8080', 'http://localhost:5001'],

server/src/logger/logger.ts

@@ -1,4 +1,5 @@
-import winston, { LogEntry } from 'winston';
+import type { LogEntry } from 'winston';
+import winston from 'winston';
 import WinstonCloudWatch from 'winston-cloudwatch';
 
 const logger = winston.createLogger({

server/src/routes/gameHandlers.ts

@@ -1,14 +1,18 @@
-import { getRoomById, Room } from '../state/rooms';
+import type { Room } from '../state/rooms';
+import { getRoomById } from '../state/rooms';
 import { GameState } from '../state/gameState';
 import { z } from 'zod';
 import logger from '../logger/logger';
 
 /*** handler validation schemas ***/
-import { isErr, isOk, isSuccess, Result } from ':common/result';
-import { SettableOptions, getSettableOptionsSchema, getVisibleOptionsSchema } from ':common/options';
-import { PollName, zPollName } from ':common/stateTypes';
-import { TypedServer, TypedSocket } from ':common/socketioTypes';
-import { Responses } from ':common/stateTypes';
+import type { Result } from ':common/result';
+import { isErr, isOk, isSuccess } from ':common/result';
+import type { SettableOptions } from ':common/options';
+import { getSettableOptionsSchema, getVisibleOptionsSchema } from ':common/options';
+import type { PollName } from ':common/stateTypes';
+import { zPollName } from ':common/stateTypes';
+import type { TypedServer, TypedSocket } from ':common/socketioTypes';
+import type { Responses } from ':common/stateTypes';
 
 const registerGameHandlers = (io: TypedServer, socket: TypedSocket) => {
   /*** GAME STATE ENDPOINTS ***/

server/src/routes/registerHandlers.ts

@@ -1,6 +1,6 @@
 import { registerRoomHandlers } from './roomHandlers';
 import { registerGameHandlers } from './gameHandlers';
-import { TypedServer, TypedSocket } from ':common/socketioTypes';
+import type { TypedServer, TypedSocket } from ':common/socketioTypes';
 
 export function registerHandlers(io: TypedServer, socket: TypedSocket) {
   registerRoomHandlers(io, socket);

server/src/routes/roomHandlers.ts

@@ -3,7 +3,7 @@ import logger from '../logger/logger';
 import { midgameJoin } from './gameHandlers';
 import { isErr } from ':common/result';
 import { z } from 'zod';
-import { TypedServer, TypedSocket } from ':common/socketioTypes';
+import type { TypedServer, TypedSocket } from ':common/socketioTypes';
 
 /*** handler validation schemas ***/
 const roomSchema = z.object({

server/src/routes/roomService.ts

@@ -1,6 +1,6 @@
 import { roomService } from '../state/rooms';
 import logger from '../logger/logger';
-import { TypedServer } from ':common/socketioTypes';
+import type { TypedServer } from ':common/socketioTypes';
 // 1 minute
 const TIMEOUT = 60 * 1000;
 // 1 second

server/src/state/gameState.ts

@@ -2,10 +2,12 @@ import { Prompts } from './prompts';
 import { getCorrections, stringMatch } from './matchUtils';
 import { PollService } from './pollService';
 import logger from '../logger/logger';
-import { Room } from './rooms';
-import { Err, Info, Ok, Result, Success, VoidResult, Warn } from ':common/result';
-import { defaultOptions, getVisibleOptionsSchema, Options, VisibleOptions } from ':common/options';
-import {
+import type { Room } from './rooms';
+import type { Result, VoidResult } from ':common/result';
+import { Err, Info, Ok, Success, Warn } from ':common/result';
+import type { Options, VisibleOptions } from ':common/options';
+import { defaultOptions, getVisibleOptionsSchema } from ':common/options';
+import type {
   Match,
   MidgameConnectData,
   PollName,

server/src/state/pollService.ts

@@ -1,6 +1,7 @@
-import { GameState } from './gameState';
-import { Err, Ok, Result, Warn } from ':common/result';
-import { PollName, Stage } from ':common/stateTypes';
+import type { GameState } from './gameState';
+import type { Result } from ':common/result';
+import { Err, Ok, Warn } from ':common/result';
+import type { PollName, Stage } from ':common/stateTypes';
 import logger from '../logger/logger';
 
 type Poll = {

server/src/state/rooms.ts

@@ -1,8 +1,9 @@
 import { GameState } from './gameState';
 import parameterize from 'parameterize';
 import locale from 'locale';
-import { Info, isErr, Ok, Result, Success, VoidResult, Warn } from ':common/result';
-import { Player } from ':common/stateTypes';
+import type { Result, VoidResult } from ':common/result';
+import { Info, isErr, Ok, Success, Warn } from ':common/result';
+import type { Player } from ':common/stateTypes';
 
 export type Room = {
   name: string;

server/tests/routes/createjoin.ts

@@ -4,7 +4,7 @@ import { io as ioc } from 'socket.io-client';
 import { type AddressInfo } from 'node:net';
 import { registerHandlers } from '../../src/routes/registerHandlers';
 import { assert } from 'chai';
-import { TypedClientSocket } from ':common/socketioTypes';
+import type { TypedClientSocket } from ':common/socketioTypes';
 
 describe('Validation tests', () => {
   let io: Server;

server/tests/routes/lobby.ts

@@ -4,8 +4,8 @@ import { io as ioc } from 'socket.io-client';
 import { type AddressInfo } from 'node:net';
 import { registerHandlers } from '../../src/routes/registerHandlers';
 import { assert } from 'chai';
-import { Player } from ':common/stateTypes';
-import { TypedClientSocket } from ':common/socketioTypes';
+import type { Player } from ':common/stateTypes';
+import type { TypedClientSocket } from ':common/socketioTypes';
 
 describe('lobby tests', () => {
   let io: Server, clientSocket1: TypedClientSocket, clientSocket2: TypedClientSocket;

server/tests/routes/promptResponse.ts

@@ -4,7 +4,7 @@ import { io as ioc } from 'socket.io-client';
 import { type AddressInfo } from 'node:net';
 import { registerHandlers } from '../../src/routes/registerHandlers';
 import { assert } from 'chai';
-import { TypedClientSocket } from ':common/socketioTypes';
+import type { TypedClientSocket } from ':common/socketioTypes';
 
 describe('promptResponse tests', () => {
   const roomName = 'room';

server/tests/routes/responseSelection.ts

@@ -4,8 +4,8 @@ import { io as ioc } from 'socket.io-client';
 import { type AddressInfo } from 'node:net';
 import { registerHandlers } from '../../src/routes/registerHandlers';
 import { assert } from 'chai';
-import { Player } from ':common/stateTypes';
-import { TypedClientSocket } from ':common/socketioTypes';
+import type { Player } from ':common/stateTypes';
+import type { TypedClientSocket } from ':common/socketioTypes';
 
 const SHARED_RESPONSE = 'sharedResponse';
 const C1_RESPONSE = 'c1Response';

server/tests/state/autoMatch.ts

@@ -1,7 +1,7 @@
 import { assert } from 'chai';
 import { GameState } from '../../src/state/gameState';
-import { Room } from '../../src/state/rooms';
-import { Player } from ':common/stateTypes';
+import type { Room } from '../../src/state/rooms';
+import type { Player } from ':common/stateTypes';
 
 describe('Automatch tests', () => {
   const selectorId = 'selector';

server/tests/state/completeCallbacks.ts

@@ -1,7 +1,7 @@
 import { GameState } from '../../src/state/gameState';
 import { assert } from 'chai';
-import { Room } from '../../src/state/rooms';
-import { Player } from ':common/stateTypes';
+import type { Room } from '../../src/state/rooms';
+import type { Player } from ':common/stateTypes';
 
 describe('Complete callback tests', () => {
   let players: Player[];

server/tests/state/pollService.ts

@@ -1,9 +1,10 @@
 import { PollService } from '../../src/state/pollService';
-import { Room } from '../../src/state/rooms';
+import type { Room } from '../../src/state/rooms';
 import { GameState } from '../../src/state/gameState';
 import { assert } from 'chai';
-import { isErr, Result } from ':common/result';
-import { Player } from ':common/stateTypes';
+import type { Result } from ':common/result';
+import { isErr } from ':common/result';
+import type { Player } from ':common/stateTypes';
 
 describe('PollVote tests', () => {
   it('unregistered poll', () => {

server/tests/state/selectionAccepts.ts

@@ -1,8 +1,8 @@
 import { assert } from 'chai';
 import { GameState } from '../../src/state/gameState';
-import { Room } from '../../src/state/rooms';
+import type { Room } from '../../src/state/rooms';
 import { isErr, isSuccess } from ':common/result';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 describe('Selection Accepting tests', () => {
   const selectorId = 'selector';

server/tests/state/selectionRotation.ts

@@ -1,7 +1,7 @@
-import { Room } from '../../src/state/rooms';
+import type { Room } from '../../src/state/rooms';
 import { GameState } from '../../src/state/gameState';
 import { assert } from 'chai';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 describe('Selection Rotation tests', () => {
   let players: Player[];

server/tests/state/sikeDispute.ts

@@ -1,7 +1,7 @@
 import { GameState } from '../../src/state/gameState';
 import { assert } from 'chai';
 import { isErr, isSuccess } from ':common/result';
-import { Player } from ':common/stateTypes';
+import type { Player } from ':common/stateTypes';
 
 describe('Sike Dispute tests', () => {
   const selectorId = '0';

server/tests/state/voteSkipPrompt.ts

@@ -1,8 +1,9 @@
 import { GameState } from '../../src/state/gameState';
 import { assert } from 'chai';
-import { Room } from '../../src/state/rooms';
-import { isOk, Result } from ':common/result';
-import { Player } from ':common/stateTypes';
+import type { Room } from '../../src/state/rooms';
+import type { Result } from ':common/result';
+import { isOk } from ':common/result';
+import type { Player } from ':common/stateTypes';
 
 describe('voteSkipPrompt tests', () => {
   // must be even