* add a couple more linting rules

ConorMurphy21 · Feb 5, 2024 · c32f0d9 · c32f0d9
1 parent d9e7889
commit c32f0d9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/client/.eslintrc.cjs b/client/.eslintrc.cjs
@@ -20,6 +20,7 @@ module.exports = {
   },
   rules: {
     '@typescript-eslint/consistent-type-imports': 2,
+    '@typescript-eslint/prefer-for-of': 2,
     '@typescript-eslint/unbound-method': 0,
     '@typescript-eslint/no-unused-vars': 0,
     '@typescript-eslint/no-unsafe-assignment': 0,

diff --git a/server/.eslintrc.cjs b/server/.eslintrc.cjs
@@ -15,7 +15,8 @@ module.exports = {
   },
   plugins: ['@typescript-eslint', 'prettier'],
   rules: {
-    '@typescript-eslint/consistent-type-imports': ['error'],
+    '@typescript-eslint/prefer-for-of': 2,
+    '@typescript-eslint/consistent-type-imports': 2,
     'prettier/prettier': 2
   },
   ignorePatterns: ['/*', '!/src', '!/tests']

diff --git a/server/src/state/prompts.ts b/server/src/state/prompts.ts
@@ -175,8 +175,8 @@ export class Prompts {
     const oldCustomPack = oldPrompts.packs[oldPrompts.packs.length - 1];
     const customPack = this.packs[this.packs.length - 1];
     for (const i of oldCustomPack.used) {
-      for (let j = 0; j < customPack.prompts.length; j++) {
-        if (oldCustomPack.prompts[i] === customPack.prompts[j]) {
+      for (const customPrompt of customPack.prompts) {
+        if (oldCustomPack.prompts[i] === customPrompt) {
           customPack.used.add(i);
         }
       }