Share types across client and server #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* definitely not working but want to work on desktop
* get server dev tools working with common package * still need to get production build working
* except resources aren't copied over to dist folder
…typescript enums have some downsides and unions are preferred
…des them in the bundle
* still need to migrate options, midgameReconnect * add typechecking to socketioClient
* refactor options a bit to make both sides agree * fix client build (resolve common imports)
* fix typing errors that ensued from that
kajgm
approved these changes
Jan 23, 2024
| packs: Record<string, boolean>; | ||
| customPrompts: string; | ||
| }; | ||
| import { SettableOptions } from ':common/options'; |
There was a problem hiding this comment.
For this and all imports from :common, do you need to declare type? i.e import { type SettableOptions } ? Is there any reason why this has to be different from how you are importing :common/player or :common/match?
There was a problem hiding this comment.
On the client side I had a linter setting or typescript setting that expected explicit type imports. Not sure how it slipped through, maybe that setting has been turned off. This was the case for all types not just common ones
ConorMurphy21
commented
Jan 24, 2024
| active: boolean; | ||
| }; | ||
|
|
||
| export type Stage = 'lobby' | 'response' | 'selection' | 'matching' | 'endRound'; |
There was a problem hiding this comment.
@kajgrant note the Stage type isn't a string, it's a union of string values. There's some weird reasons that string unions tend to be preferred over const enums in typescript.
jengu288
reviewed
Jan 24, 2024
ConorMurphy21
deleted the
187-share-datatypes-across-server-and-client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.