158 buttons dont indicate that the user has already clicked #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-user-has-already-clicked' into 158-buttons-dont-indicate-that-the-user-has-already-clicked # Conflicts: # client/src/components/endRound/EndRound.vue # client/src/components/promptResponse/VoteSkip.vue # client/src/components/responseMatching/DisputeIcon.vue
ConorMurphy21
approved these changes
Jan 26, 2024
jengu288
deleted the
158-buttons-dont-indicate-that-the-user-has-already-clicked
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the behaviour of buttons that persist after being clicked: Voting to skip a prompt, end the round, and dispute things.
Unclicked:
Clicking darkens the button's white component, removes the dropshadow to "flatten" the button, and records vote on the badge icon:
When the next vote will cause an action to occur, the badge turns orange:
Current player has not clicked, but another player has:
Similar examples with thumbs down icon:
