Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

168 improve UI regarding minimum and maximum players in a room #201

Merged

Conversation

jengu288
Copy link
Collaborator

@jengu288 jengu288 commented Mar 11, 2024

image

Currently have the recommended number of players as 5. If you have more than 5 players, a modal pops up prompting you to split into two lobbies.

Styling is up for discussion, as well as text.

image

Modified Final Styling

@jengu288 jengu288 self-assigned this Mar 11, 2024
@jengu288 jengu288 linked an issue Mar 11, 2024 that may be closed by this pull request
Copy link
Owner

@ConorMurphy21 ConorMurphy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, ready to merge once the comments and linting errors are addressed and the description string is changed. :)

client/src/App.vue Outdated Show resolved Hide resolved
client/src/stores/game.ts Outdated Show resolved Hide resolved
common/src/options.ts Outdated Show resolved Hide resolved
common/src/options.ts Outdated Show resolved Hide resolved
@jengu288 jengu288 merged commit 80a9611 into master Mar 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve UI regarding minimum and maximum players in a room
2 participants