Autoload issue with ImpressionistController #2
Conversation
Instead of depending on autoload to bring in the `ImpressionistController` constant, we manually bring it with a call to `require` and just move that file to `lib`. Prior to this, Rails would emit a warning on startup about needing to use autoload durning an initializer like this, letting us know that a future version of Rails will error from this. This should hopefully remove that error and still allow these controller mixins to be available. Co-authored-by: stefannibrasil <[email protected]>
| @@ -20,7 +20,7 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.add_dependency "friendly_id" | |||
| s.add_dependency 'nokogiri', RUBY_VERSION < '2.1.0' ? '~> 1.6.0' : '~> 1' | |||
| s.add_dependency 'rails', '>= 3.2.15' | |||
| s.add_dependency 'rails', '>= 3.2.15', '< 7.1' | |||
There was a problem hiding this comment.
Without this constraint, we were getting an ArgumentError when creating a Rails 7.1 app.
| @@ -53,14 +53,14 @@ Layout/BlockAlignment: | |||
| # Cop supports --auto-correct. | |||
| Layout/ClosingParenthesisIndentation: | |||
| Exclude: | |||
There was a problem hiding this comment.
All of the changes in this file are because we needed to rename the previous file to the new file inside of /lib.
I did a quick search and based on this comment from @mercedesb, we only use it for tracking the Landing pages visitors: https://convertkit.slack.com/archives/CHZGVGC2W/p1686947789442399 but it looks like this is an old question: https://convertkit.slack.com/archives/C02G2JWUX/p1578402933118100 |
Instead of depending on autoload to bring in the
ImpressionistControllerconstant, we manually bring it with a call torequireand just move that file tolib.Prior to this, Rails would emit a warning on startup about needing to use autoload durning an initializer like this, letting us know that a future version of Rails will error.
This should hopefully remove that error and still allow these controller mixins to be available.
PS. This is the recommended approach by Xavier here charlotte-ruby#305