Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed dependence on environment variables by allowing variables to be set on instantiation #10

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

itsterry
Copy link

@itsterry itsterry commented Jan 4, 2023

I've made it so that you can specify client_id, client_secret, and redirect_uri at the same time as auth_token, like this:

client = InstagramBasicDisplay::Client.new(auth_token: token, 
                                           client_id: client_id, 
                                           client_secret: client_secret, 
                                           redirect_uri: redirect_uri)

This allows people to store their credentials in any of the other secure methods (Rails.application.credentials, etc)

I've also removed the bundler versioning restriction and the Ruby version restriction (they were getting a little old)

@yshmarov
Copy link

really great addition! I really prefer using rails credentials VS env vars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants