feat: request observers to intercept requests and responses #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results 🚀649 tests ±0 648 ✅ - 1 2m 37s ⏱️ -22s For more details on these failures, see this check. Results for commit b1e41ff. ± Comparison against base commit 9669272. ♻️ This comment has been updated with latest results. |
| @@ -494,6 +502,10 @@ public void run() { | |||
| L.v("[ConnectionProcessor] Response was a unknown, will retry"); | |||
| rRes = RequestResult.RETRY; | |||
| } else { | |||
| // notify observers for the response | |||
There was a problem hiding this comment.
add tests for this
|
also fix codacy |
|
le conflic |
|
we might omit this PR for now, this was needed for content update from RQ but we are not doing that anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for module content's fetching mechanism