Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed new features: filtering, distortion and convolution (reverb) #238

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Commits on Mar 28, 2016

  1. add a filterNode to the audioNode chain, so the order to master outpu…

    …t is now filterNode=>panNode=>gainNode. Added properties to store the filter's frequency and q factor. These properties can be directly set or get from the sound instance, in the same manner as pan
    tyler-g committed Mar 28, 2016
    Configuration menu
    Copy the full SHA
    f251999 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2016

  1. Configuration menu
    Copy the full SHA
    18d6acc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a0adca2 View commit details
    Browse the repository at this point in the history
  3. add a distortionNode to the chain. This comes before the filterNode s…

    …o the order is now: distortionNode => filterNode => panNode => gainNode. The distortion amount can be changed by distortionAmount public property on the sound instance. Oversampling is hardcoded to 4x currently.
    tyler-g committed Apr 1, 2016
    Configuration menu
    Copy the full SHA
    164eb1b View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2016

  1. add a convolverNode to the chain, which is now distortion node => fil…

    …ter node => convolver node => pan node => gain node. Added ability to set/get the buffer of the convolverNode. This can be set with an AudioBuffer directly, or with a filepath to an impulse response. In the latter case, soundjs will read and decode the file automatically, and set the convolver buffer. Note currently there seems to be a bug where only stereo impulse responses will work. Mono impulse responses (or null buffer on the convolver node) will case the convolver node to output no audio. May need to find a way to bypass the convolver node completely if buffer is null or not set properly. Otherwise chain will to destination will break without proper care
    tyler-g committed Apr 4, 2016
    Configuration menu
    Copy the full SHA
    2d69b96 View commit details
    Browse the repository at this point in the history