Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix basePath edge-case in registerSound #322

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix basePath edge-case in registerSound #322

wants to merge 1 commit into from

Commits on Jan 13, 2020

  1. Fix basePath edge-case in registerSound 

    When calling registerSound with an object for src, like for instance
when handling a data URL with { src: { mp3: ... }, type: "sound" }, the
id would get set as a basePath, and some inconsistent treatment of falsy
values would lead to the id getting prepended to the URL. This fixes
things so that sounds can be registered with data URLs.
    @porglezomp
    porglezomp committed Jan 13, 2020
    Configuration menu
    Copy the full SHA
    7026a0e View commit details
    Browse the repository at this point in the history