Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use actual remaining items to calculate remainders for basin recipes #7076

Open
wants to merge 1 commit into
base: mc1.20.1/dev
Choose a base branch
from

Conversation

PssbleTrngle
Copy link
Contributor

This is a proposed fix for #6963.

This PR solves the there mentioned problem by using the same method to calculate remainder items as it is used for shapeless crafting recipes.

Here are two example recipes to test the bug and it's solution with:

Recipe 1
{
"type": "create:mixing",
"ingredients": [
  {
    "item": "water_bucket"
  },
  {
    "tag": "forge:ingots/zinc"
  }
],
"results": [
  {
    "count": 2,
    "item": "diamond"
  }
]
}
Recipe 2
{
"type": "create:mixing",
"ingredients": [
  {
    "item": "water_bucket"
  },
  {
    "item": "lava_bucket"
  }
],
"results": [
  {
    "count": 1,
    "item": "obsidian"
  }
]
}

@IThundxr IThundxr added pr type: fix PR fixes a bug pr flag: simple PR has minimal changes labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr flag: simple PR has minimal changes pr type: fix PR fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants