Minor fixes related to HLS Input and FreeBSD compilation #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dacolboy
changed the title
|
It took us forever to get around to looking at this, apologies for that! We don't really have any good way to test FreeBSD support, and I think quite a few of the other changes in this PR are now probably outdated (we've switched from CMake to Meson, and HLS input was more or less completely rewritten since 2023), but if you're still interested happy to take a look at this again, especially if you can update this PR to be against the latest No hard feelings if you're no longer interested, but then we'll probably close this PR unmerged as it would be quite tricky for us to properly update and test this otherwise. 🤔 |
|
Hi Jaron! No worries, actually I think most of the fixes in this PR are already fixed in the new versions, so feel free to close it.
Thank you anyway for checking in.
Keep up the good work!
Best,
David.
On 16 May 2024, at 18:02, Jaron Viëtor ***@***.***> wrote:
It took us forever to get around to looking at this, apologies for that!
Are you still interested in upstreaming this?
We don't really have any good way to test FreeBSD support, and I think quite a few of the other changes in this PR are now probably outdated (we've switched from CMake to Meson, and HLS input was more or less completely rewritten since 2023), but if you're still interested happy to take a look at this again, especially if you can update this PR to be against the latest development branch. 😅
No hard feelings if you're no longer interested, but then we'll probably close this PR unmerged as it would be quite tricky for us to properly update and test this otherwise. 🤔
—
Reply to this email directly, view it on GitHub<#160 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AQ5W7R36NFIDXVGBZAULTYLZCTKCVAVCNFSM6AAAAAAULFPWUKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGYZTENZZGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.